Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: declare dependency "buf.build/googleapis/googleapis" #111

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: declare dependency "buf.build/googleapis/googleapis" #111

merged 1 commit into from
Nov 27, 2023

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Nov 23, 2023 •
edited
Loading

Description

When you run buf generate ./proto in the root directory, you will receive the following warning: In fact, the dependency description is lacking.

WARN    bufimagebuild   File "cosmwasm/wasm/v1/query.proto" imports "google/api/annotations.proto", which is not found in your local files or direct dependencies, but is found in the transitive dependency "buf.build/googleapis/googleapis". Declare dependency "buf.build/googleapis/googleapis" in the deps key in buf.yaml.

This is a PR to correct this warning.
Declaring the dependency resolves the warning.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md (not needed)
  • I have added tests to cover my changes. (not needed)
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

@Kynea0b Kynea0b self-assigned this Nov 23, 2023
@Kynea0b Kynea0b added the bug Something isn't working label Nov 23, 2023
@170210
Copy link

170210 commented Nov 27, 2023

Is it necessary to specify a version or commit bash as in cosmwasm/wasmd?
https://github.com/CosmWasm/wasmd/blob/main/proto/buf.yaml

@Kynea0b
Copy link
Author

Kynea0b commented Nov 27, 2023 •
edited
Loading

@170210
Thank you for confirming.
I think it will be necessary.
Currently, I think it is better to leave it unspecified for the following reasons.

  • Other dependent specifications such as buf.build/cosmos/gogo-proto and buf.build/cosmos/cosmos-proto are also not specified.
  • We are currently considering the version of cosmos-sdk.

Version specification has been made into a separate issue.
#112

@Kynea0b Kynea0b merged commit c83ad2f into Finschia:main Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@170210 170210 170210 approved these changes

@da1suk8 da1suk8 da1suk8 approved these changes

@loloicci loloicci Awaiting requested review from loloicci

Assignees

@Kynea0b Kynea0b

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kynea0b @170210 @da1suk8